Add tests for BatchCoalescer::push_batch_with_filter, fix bug
#7774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
force-pushed
the
alamb/tests_for_push_filtered
branch
from
60beecd to
65604c5
Compare
alamb
commented
Jun 25, 2025
| @@ -456,6 +460,98 @@ mod tests { | |||
| .run(); | |||
| } | |||
|
|
|||
| /// Coalesce multiple batches, 80k rows, with a 0.1% selectivity filter | |||
There was a problem hiding this comment.
The idea is to get filter coverage prior to writing some specialized code for it
alamb
changed the title
BatchCoalescer::push_batch_with_filterBatchCoalescer::push_batch_with_filter, fix bug
alamb
commented
Jul 10, 2025
| use std::fmt::Debug; | ||
| use std::sync::Arc; | ||
|
|
||
| /// InProgressArray for [`PrimitiveArray`] | ||
| #[derive(Debug)] | ||
| pub(crate) struct InProgressPrimitiveArray<T: ArrowPrimitiveType> { | ||
| /// Data type of the array | ||
| data_type: DataType, |
There was a problem hiding this comment.
previously primitive arrays like TimestampNanosecond would lose the timezone information. This fixes the issue
mbrobbel
approved these changes
Jul 14, 2025
|
Opened apache/arrow-js#205 for the failing test (passed after retry). |
|
Thank you @mbrobbel |
|
Thanks agin @mbrobbel |
klion26
added a commit
to klion26/arrow-rs
that referenced
this pull request
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
push_batch_with_filterfor primitive array #7762Rationale for this change
As part of #7762 I want to optimize applying filters by adding a new code path.
To ensure that works well, let's ensure the filtered code path is well covered with tests
What changes are included in this PR?
Are these changes tested?
Only tests, no functional changes
Are there any user-facing changes?