feat: support conversion of chunked arrays #553
Merged
+292
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
requested changes
Oct 28, 2025
| ) | ||
|
|
||
| func TestChunksToSingle(t *testing.T) { | ||
| mem := memory.NewGoAllocator() |
There was a problem hiding this comment.
Can we use a CheckedAllocator and assert the size to ensure we don't have any memory leak?
|
Thank you @zeroshade for the review! I applied the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Fixes #552
What changes are included in this PR?
Make
chunksToSingleconcatenate multiple chunks into a single array usingarray.Concatenateinstead of returningErrNotImplementedAre these changes tested?
Unit tests + tested end-to-end locally on a parquet file that contains chunked arrays
Are there any user-facing changes?
Changes are backward compatible