[Go] [Parquet] pqarrow file-writer & row-group-writer tracking total & total compressed bytes #548
+118
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeroshade
reviewed
Oct 27, 2025
Comment on lines
+118
to
+119
| fw.totalCompressedBytes += fw.rgw.TotalCompressedBytes() | ||
| fw.totalBytesWritten += fw.rgw.TotalBytesWritten() |
There was a problem hiding this comment.
In FileWriter.Close when we write the metadata, we should probably add the size of the metadata we write to the total bytes written, yea?
Comment on lines
+174
to
+175
| assert.Greater(t, writer.TotalCompressedBytes(), int64(0)) | ||
| assert.Greater(t, writer.TotalBytesWritten(), int64(0)) |
There was a problem hiding this comment.
since we're creating the test and know the settings, we can probably know the exact size to test for and have the test be explicit on the size we expect so that we know if we break anything in the future. Make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
As discussed in issue, pqarrow parquet writer when writing more than 1 row group, it cannot track the bytesWritten & compressedbytesWritten for closed row group.
The method
RowGroupTotalCompressedBytes&RowGroupTotalBytesWrittenonly returns the current row group.The ideal is to introduce
TotalCompressedBytes()&TotalBytesWritten()as an enhancement for user to track all row group written bytes & compressed bytes.What changes are included in this PR?
As part of making this change, I notice the totalCompressedBytes is not being populated correctly in
row_group_writer.go.It should follow the same approach as
bytesWrittenwhere it tracks all the closed column_writer.Are these changes tested?
Yes. I added test cases to ensure those metrics are populated correctly
Are there any user-facing changes?
Yes. There are two new methods introduced:
It won't impact on existing users.