Use ParseFloat with json.Number in Int64/Uint64 Builders' UnmarshalOne #475
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need to do this for ALL the integer types? not just int64/uint64? Can you add a relevant test case for this please? |
|
FWIW, while exploring issues and PRs, I noticed that using ParseFloat isn’t the right solution. The problem is that it loses precision for integers larger than 2^53 (for example, "9007199254740993" gets converted to 9.007199254740993e+15). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Addresses #474
What changes are included in this PR?
Replaced
strconv.ParseInt/strconv.ParseUintwithstrconv.ParseFloatin Int64/Uint64Builder.UnmarshalOneAre these changes tested?
Existing tests pass.
Are there any user-facing changes?
No