perf(etcd): refactor some code to improve performance #12011
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
Before:
The original code performed a cleanup of
self.values
and rebuiltself.values_hash
by:self.values
nil
valuesvalues_hash
in a separate stepProblems:
Now:
nil
values while keeping the same tablevalues_hash
at the same timeWhy better?
Before:
The original code performed a cleanup of
self.values
and rebuiltself.values_hash
by:self.values
nil
valuesvalues_hash
in a separate stepProblems:
Now:
nil
values while keeping the same tablevalues_hash
at the same timeWhy better?
Checklist