refactor(google-cloud-logging): unify google-cloud-oauth.lua file #11596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shreemaan-abhishek Sorry, I forgot to update the document before. Please reiview it again when you have time.Thanks. |
shreemaan-abhishek
previously approved these changes
Sep 26, 2024
moonming
previously approved these changes
Sep 26, 2024
HuanXin-Chen
dismissed stale reviews from moonming and shreemaan-abhishek
via
4f1c2f5
dosubot
bot
added
size:L
|
@bzp2010 @moonming @shreemaan-abhishek I have made some new changes: I added a scopes field without a default value to maintain compatibility with existing apisix users. When the user originally configured the scopes, the scopes will be assigned to the scope, ensuring compatibility. If the user did not configure the scopes, they will use the default value of scope or the scope value configured by the user. Please reiview it again when you have time.Thanks. |
bzp2010
previously approved these changes
Oct 3, 2024
shreemaan-abhishek
previously approved these changes
Oct 3, 2024
moonming
previously approved these changes
Oct 3, 2024
HuanXin-Chen
dismissed stale reviews from moonming, shreemaan-abhishek, and bzp2010
via
9c772e7
bzp2010
approved these changes
Oct 3, 2024
|
All fixed🫡 |
shreemaan-abhishek
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: unify
google-cloud-logging/oauth.luaandutils/google-cloud-oauth.luafile · Issue #11576 · apache/apisix (github.com)What I do :
● scopes -> scope : according to OAuth2/OIDC rules, scope should not be used in the plural
● using utils/google-cloud-oauth.lua replace google-cloud-logging/oauth.lua
Checklist