fix: httpc connection close

[madhawa-gunasekara]

Description

This will close httpc connection. We observed too many connections in activemq.

Fixes #11449

Checklist

• I have explained the need for this PR and the problem it solves
• I have explained the changes or the new features added to this PR
• I have added tests corresponding to this change
• I have updated the documentation to reflect this change
• I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

[shreemaan-abhishek]

great catch 🙏🏼 , could you please check if this bug exists in other plugins/places too?

[zhoujiexiong]

What about reusing socket by request_uri + keepalive instead of new + close socket every time?

like plugins/forward-auth:

[zhoujiexiong]

request_uri will close(sock) before returning, so this line is not necessary? The same is true elsewhere of the PR.

[madhawa-gunasekara]

+1 will remove it.

[shreemaan-abhishek]

@madhawa-gunasekara, please avoid force pushing 🙂 I have told this before.

[zhoujiexiong]

Ping @madhawa-gunasekara :D

[zhoujiexiong]

Ping @madhawa-gunasekara

:D

[madhawa-gunasekara]

Hi @zhoujiexiong,

I was traveling, I will push the changes. :)

[madhawa-gunasekara]

@zhoujiexiong I did the changes.. please review

[madhawa-gunasekara]

@zhoujiexiong Ping, any chance to look into this

[github-actions]

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

[github-actions]

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.