Add pre-commit that verifies if shared project are properly structured

[potiuk]

Some basic checks for structure of the shared projects - includig package structure and pyproject.toml contents.

---

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

[potiuk]

First small pre-commit - for now just checking if shared projects are properly structured.

[potiuk]

I also moved "test_timezones" to "timezones" subpackage to add a namespace for tests - when we run the tests from IDE, all tests folders are part of the same namespace so we should namespace them too to not get confused with tests from other distributions.

[potiuk]

Also maybe it's good to also add "airflow_shared" implicit package for "tests" (for even better namespacing?) WDYT?

[potiuk]

I am also thinking about globally changing other namespaces of ours "the unit, system, integration" at the top level of "tests" is quite confusing so maybe we could introduce a convention similar to:

• tests/airflow_providers/{unit,system,integration}/provider/
• tests/airflow_core/{unit,system,integration}/something
• tests/airflow_shared/{unit}/timezones

That would make some of the cross-package imports much more 'reasonable"

from unit.amazon -> from airflow_providers.unit.amazon

Maybe that would be our target convention?

I am happy to raise a question / proposal at the devlist if we think it is a good idea. We can do it all with implicit namespaces.

[potiuk]

Also we could potentially do "from airflow_providers/amazon/unit" which seems a bit more logical, but it will complicate a bit the selection of tests to execute (but it's also possible).

[amoghrajesh]

I am also thinking about globally changing other namespaces of ours "the unit, system, integration" at the top level of "tests" is quite confusing so maybe we could introduce a convention similar to:

• tests/airflow_providers/{unit,system,integration}/provider/
• tests/airflow_core/{unit,system,integration}/something
• tests/airflow_shared/{unit}/timezones

That would make some of the cross-package imports much more 'reasonable"

from unit.amazon -> from airflow_providers.unit.amazon

Maybe that would be our target convention?

I am happy to raise a question / proposal at the devlist if we think it is a good idea. We can do it all with implicit namespaces.

I like it. Will follow up on your email.

[amoghrajesh]

I have a few comments here, but its looking nice generally.

BTW, no need to backport it.

[potiuk]

Nice copilot, good copilot :D

[amoghrajesh]

Niceee! Love it!

[potiuk]

I merge it for now - we can also restructure tests/structure separately.

[github-actions]

Backport failed to create: v3-0-test. View the failure log Run details

Status	Branch	Result
❌	v3-0-test

You can attempt to backport this manually by running:

cherry_picker e3ddf97 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue