-
Notifications
You must be signed in to change notification settings - Fork 15.1k
Transition of list
airflowctl config command
#50292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition of list
airflowctl config command
#50292
Conversation
@bugraoz93 referencing our discussion in #49601, could you please take a look if this implementation of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update! Direction is good. The only thing is there is no direct list command. We either need to utilise get
and loop through the entire configuration or implement a simple list on the API side and keep these newly added pieces
See endpoints: https://github.com/apache/airflow/blob/main/airflow-core%2Fsrc%2Fairflow%2Fapi_fastapi%2Fcore_api%2Froutes%2Fpublic%2Fconfig.py
@bugraoz93 Thanks for the review! Just wanted to clarify—I was using the endpoint below to get all configs while implementing the airflow/airflow-core/src/airflow/api_fastapi/core_api/routes/public/config.py Lines 97 to 98 in 3936683
This is the what the current
If the goal is to format it more like this:
Would it be correct to assume this is just a matter of formatting? Or am I missing something deeper in the implementation? Happy to adjust if needed—just want to make sure I fully understand your feedback. Appreciate your insights! |
Exactly, this is the case. In this one, directly calling the API endpoint is returning what we want, so only implementing the operations is enough in this case.
We only need to add and update a small part in the unit test for operations. Direction is good. Thanks for the update! |
list
airflowctl config commandlist
airflowctl config command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks!
b4687e2
to
2343dd4
Compare
partially closes: #45664
parent issue: #45661
implements
list
config command by adding alist
method toConfigOperations
.