add readiness and liveliness support for git sync relay sidecars #50218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgvishnuram
requested review from
dstandish,
jedcunningham and
hussein-awala
as code owners
|
@hussein-awala @dstandish can i get a review on this PR |
|
Internal Issue link for reference -> https://github.com/astronomer/issues/issues/6929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds support for liveliness and readiness probe configuration to airflow sidecar container when gitsync is enabled and additional adds a skip condition for git sync initContainers which does not support probes as per kubernetes schema
Motivation
This is quite useful in places where companies has strict requirement of defining probes in all containers