Skip NoneType start/end times when computing data interval for events #50217
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Skip NoneType start/end timestamps in data_interval_for_events to avoid errors when source_dag_run is partially populated
uranusjr
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache Airflow version
2.10.2 (GCP Composer v2)
What happened?
During DAG execution, especially under out-of-capacity conditions, the
start_dateandend_datefields may be missing. This causes the Airflow Scheduler on GCP to fail during recovery, resulting in the following error:What you think should happen instead?
The function should validate the presence of both start_date and end_date before attempting to compute the minimum and maximum timestamps. Missing values should be skipped to prevent scheduler crashes.
How to reproduce:
Create a DAG run entry in the Airflow metadata database with a NULL (empty) start_date or end_date. When this DAG run is processed, the scheduler will raise a TypeError.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.