ensure BitVec deser has correct len/cap #8488
Open
+14
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible to get
BitVec
into an invalid state when deserializing under the following conditions:T
), because all sequence lengths are encoded asu64
NUM_WORDS
This can trigger a panic, because boundary checks use constants like
NUM_WORDS
andNUM_BITS
, which are meaningless if the inner vec's state is out of sync with themSummary of Changes
Deserialize
impl ofBitVec
now ensures it has the expected number of words