Skip to content

Conversation

kskalski
Copy link

@kskalski kskalski commented Oct 15, 2025

Problem

snapshot_config depends on constants and type from snapshot_utils that are directly used and related to config and which utils could easily import from config

Summary of Changes

  • Move SnapshotVersion to snapshot_config
  • Move default values for config to snapshot_config
  • update all uses

(this change will allow a cleaner move of snapshot_config to new agave-snapshots crate added in #8382)

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.1%. Comparing base (0199a3a) to head (1a3c594).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #8487    +/-   ##
========================================
  Coverage    83.1%    83.1%            
========================================
  Files         840      840            
  Lines      367669   367668     -1     
========================================
+ Hits       305719   305870   +151     
+ Misses      61950    61798   -152     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kskalski kskalski requested a review from steviez October 15, 2025 07:48
@kskalski kskalski marked this pull request as ready for review October 15, 2025 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants