Skip to content

Refactor: Removed unused CSS properties from style.module.css #8465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Refactor: Removed unused CSS properties from style.module.css #8465

wants to merge 3 commits into from
+1 −36

Conversation

letmehateu
Copy link

@letmehateu letmehateu commented Oct 14, 2025 •
edited
Loading

Problem

  • The styles.feature class was being used in Card.jsx but was not defined in the corresponding styles.module.css file
  • styles.module.css had a lot of unused properties

Summary of Changes

  • Removed reference to undefined styles.feature class in Card.jsx
  • Removed unused properties in styles.module.css

Before my changes
telegram-cloud-photo-size-2-5438339568345678620-y
After my changes
telegram-cloud-photo-size-2-5438339568345678618-y

Fixes #

@mergify mergify bot requested a review from a team October 14, 2025 05:55
@mergify mergify bot mentioned this pull request Oct 14, 2025
Closed
0xbrw
0xbrw requested changes Oct 14, 2025
View reviewed changes
Copy link

@0xbrw 0xbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In pr description can you include before/after UI changes to make sure this is unused.

steviez
steviez reviewed Oct 14, 2025
View reviewed changes
Copy link

@steviez steviez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why did you make a new PR and close #7790 ?

@letmehateu
Copy link
Author

In pr description can you include before/after UI changes to make sure this is unused.

I tested it without my changes, and you can see that styles.feature in Card.jsx not used
telegram-cloud-photo-size-2-5438339568345678607-y

And as you ask
telegram-cloud-photo-size-2-5438339568345678618-y
telegram-cloud-photo-size-2-5438339568345678620-y

@letmehateu
Copy link
Author

Also, why did you make a new PR and close #7790 ?

Sorry, a month and a half passed and I thought you lost my PR

@letmehateu letmehateu requested a review from 0xbrw October 14, 2025 20:16
@0xbrw 0xbrw added the CI Pull Request is ready to enter CI label Oct 14, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Oct 14, 2025
0xbrw
0xbrw approved these changes Oct 14, 2025
View reviewed changes
Copy link

@0xbrw 0xbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally UI is the same

@letmehateu
Copy link
Author

Verified locally UI is the same

sorry, so can we merdge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@steviez steviez steviez left review comments

@0xbrw 0xbrw 0xbrw approved these changes

Assignees

No one assigned

Labels

community need:merge-assist

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@letmehateu @steviez @0xbrw @anza-team