ledger: Build the grouped slot leaders manually #8451
+38
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
compute-epoch-schedule-group-map
branch
2 times, most recently
from
e42e215 to
cb8fedb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8451 +/- ##
=======================================
Coverage 83.2% 83.2%
=======================================
Files 841 841
Lines 368425 368438 +13
=======================================
+ Hits 306635 306687 +52
+ Misses 61790 61751 -39 🚀 New features to boost your workflow:
|
vadorovsky
force-pushed
the
compute-epoch-schedule-group-map
branch
from
cb8fedb to
37b32a9
Compare
Building them with `itertools::into_group_map` takes 20.9ms. Building them manually with a pre-allocated hash map, using pubkey hasher, takes 5.2ms.
vadorovsky
force-pushed
the
compute-epoch-schedule-group-map
branch
from
37b32a9 to
b758fe5
Compare
HaoranYi
reviewed
Oct 14, 2025
| slot_leaders: Vec<Pubkey>, | ||
| // Inverted index from pubkeys to indices where they are the leader. | ||
| leader_slots_map: HashMap<Pubkey, Arc<Vec<usize>>>, | ||
| leader_slots_map: HashMap<Pubkey, Vec<usize>, PubkeyHasherBuilder>, |
There was a problem hiding this comment.
We might need to change this fn to not cloning the vec anymore since it is no longer an Arc.
|
Excellent work! I have just one comment! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building them with
itertools::into_group_maptakes 20.9ms.Summary of Changes
Building them manually with a pre-allocated hash map, using pubkey hasher, takes 5.2ms.
Ref: #8280