Move set_perms from accounts-db hardened_unpack to file_io #8439
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
set_perms
in hardened_unpack is callingcrate::file_io::set_file_readonly
for a non-unix platforms which introduces a bit weird dependency (i.e. windows-only API)set_file_readonly
call actually ignores themode
, which matches the way we currently callset_perms
in hardened_unpack (set files as writable, I suppose for mmap functionality), but we could as well follow the passed modeset_file_readonly
is used in both file_io and hardened_unpack, but those calls can be replaced with a call to more generic set path permissions functionSummary of Changes
set_perms
to file_io asset_path_permissions
set_file_readonly
and replace calls withset_path_permissions
Note: this PR will be useful for cleaner change when extracting hardened_unpack into dedicated agave-snapshots crate (#8428)