Skip to content

Conversation

GarmashAlex
Copy link

  • bytes_to_store: now states it returns the canonical payload for blockstore.
  • resize_stored_shred: clarified it only validates Merkle Data payload size and returns it unchanged; it does not perform zero padding.
  • capacity: removed outdated “None indicates a legacy data-shred” note and clarified that proof_size is the number of Merkle proof entries and resigned indicates presence of a retransmitter signature.

The previous comments were misleading: they suggested possible zero-padding (which is not implemented) and referenced a legacy Option-based API that no longer exists.

@mergify mergify bot requested a review from a team October 10, 2025 08:16
@0xbrw
Copy link

0xbrw commented Oct 13, 2025

@alexpyattaev are able to take a look at this?

@alexpyattaev alexpyattaev requested a review from steviez October 14, 2025 04:28
@alexpyattaev alexpyattaev added the CI Pull Request is ready to enter CI label Oct 14, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Oct 14, 2025
@alexpyattaev
Copy link

Thanks for looking at this, these comments are remnants of the legacy shred removal.

To be frank I think we can axe the entire function, as it is essentially a noop (as shred length should be validated during deserialization). @steviez wdyt?

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.1%. Comparing base (1cc3011) to head (d43b266).
⚠️ Report is 24 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8426   +/-   ##
=======================================
  Coverage    83.1%    83.1%           
=======================================
  Files         838      838           
  Lines      367672   367672           
=======================================
+ Hits       305891   305903   +12     
+ Misses      61781    61769   -12     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexpyattaev alexpyattaev self-requested a review October 15, 2025 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants