Skip to content

Conversation

Arrowana
Copy link

@Arrowana Arrowana commented Sep 2, 2025

Problem

anza made the hacky mollusk thing that doesn't work properly with instructions sysvar, because it is well, hacky.

The main issue is that it runs instruction one by one even if they belong to the same transaction with process_instructions_chain

anza-xyz/mollusk#156 The problem blocks this

Summary of Changes

Expose setting top_level_instruction_index on TransactionContext

Can we afford this smell?

Copy link

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine by me if we just put it under the dev-context-only-utils feature!

@Arrowana Arrowana force-pushed the set-top-level-instruction-index branch from 148d762 to adc3f29 Compare September 15, 2025 20:10
@Arrowana
Copy link
Author

I think it's fine by me if we just put it under the dev-context-only-utils feature!

done

@buffalojoec buffalojoec added the CI Pull Request is ready to enter CI label Sep 16, 2025
@anza-team anza-team removed the CI Pull Request is ready to enter CI label Sep 16, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.9%. Comparing base (1254878) to head (adc3f29).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #7845     +/-   ##
=========================================
- Coverage    82.9%    82.9%   -0.1%     
=========================================
  Files         823      823             
  Lines      360410   360413      +3     
=========================================
- Hits       299008   298976     -32     
- Misses      61402    61437     +35     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@buffalojoec buffalojoec merged commit 8ff0feb into anza-xyz:master Sep 16, 2025
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants