Skip to content

React@18 #1093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

React@18 #1093

wants to merge 25 commits into from

Conversation

ra3orblade
Copy link
Contributor

@ra3orblade ra3orblade commented Dec 9, 2024


  • I understand that contributing to this repository will require me to agree with the CLA

Description

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Sorry, something went wrong.

@ra3orblade ra3orblade self-assigned this Dec 9, 2024
Copy link

socket-security bot commented Dec 9, 2024

Review the following changes in direct dependencies. Learn more about Socket for GitHub ↗.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​react-pdf/​renderer@​4.3.09910010094100

View full report ↗

@reneleonhardt
Copy link

@ra3orblade Wow, great work! Would you still be interested to rebase? I hope the maintainers can review it soon! 🤞

@ra3orblade
Copy link
Contributor Author

@ra3orblade Wow, great work! Would you still be interested to rebase? I hope the maintainers can review it soon! 🤞

what do you mean?

@reneleonhardt
Copy link

Can you see the Resolve conflicts button? Your changes can't be merged into main at the moment.

@ra3orblade
Copy link
Contributor Author

Can you see the Resolve conflicts button? Your changes can't be merged into main at the moment.

I can see it of course, I did 20k commits into this repo, lol

@reneleonhardt
Copy link

I can see it of course, I did 20k commits into this repo, lol

I meant no offense, just saw the conflicts after 4 months 😅
It seems no maintainer reviewed this, who has permissions?

@ra3orblade
Copy link
Contributor Author

I can see it of course, I did 20k commits into this repo, lol

I meant no offense, just saw the conflicts after 4 months 😅 It seems no maintainer reviewed this, who has permissions?

I'm the maintainer, this PR is not finished yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants