-
-
Notifications
You must be signed in to change notification settings - Fork 24.9k
Adds the ability to include data from organization repositories #2459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rickstaa
wants to merge
13
commits into
anuraghazra:master
Choose a base branch
from
rickstaa:add_role_param
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
45e211e
Include all repo w/ access to
developStorm 41e4424
parameterize affiliation
developStorm b784962
Use GraphQL variable syntax
developStorm f19d94f
Custom ownerAffiliations for general stats
developStorm dfc44b6
Add default affiliation
developStorm f61a225
Apply patches
developStorm 66c3cd6
Merge branch 'anuraghazra-master'
developStorm 7c43e41
Merge branch 'master' into developStorm/master
rickstaa d363f5b
Merge branch 'master' into developStorm/master
rickstaa f344673
feat: parse role parameter
rickstaa 6cf8202
Merge branch 'master' into add_role_param
rickstaa 653f660
fix: fix language card ownerAffiliation bug
rickstaa 522ec4b
Merge branch 'master' into add_role_param
rickstaa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well I totally forgot what this ownerAffiliation does, but why does this need to be controlled by the user?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do not. Another option I looked at was to use a
include_orgs
variable and only add theCOLLABORATOR
flag. I did this in #2277, but people had problems (see #1 (comment)). For some reason, when you are the creator of a repository, you have to add yourself as a collaborator since github does not do this automatically even though you have contributed to the repository (see #1 (comment)).In short, due to limitations in the GraphQL API, there currently is no clean way to implement this. The only way to get the language data in all repositories a user contributed is by looping through the commits, which is infeasible given the current GraphQL and Vercel rate limits. 😅 I created a feature request to improve this, but I think it's improbable GitHub will implement this (see community/community#18230 and community/community#36108).
I'm therefore also okay with not merging an organization-related PR at all, but I just thought implementing it as a (hidden) experimental feature might help some people who code most of their projects in organizations. 🤔👍