Skip to content

fix: tooltip when shown and next not enable, hide tooltip #7462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2025
Merged

fix: tooltip when shown and next not enable, hide tooltip #7462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/g6/src/plugins/tooltip.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,12 @@ export class Tooltip extends BasePlugin<TooltipOptions> {
const { getContent, title } = this.options;
const items: ElementDatum[] = this.getElementData(id, targetType as ElementType);

if (!this.tooltipElement || !this.isEnable(event, items)) return;
if (!this.tooltipElement) return;
// if shown, when is not enable, hide
if (!this.isEnable(event, items)) {
this.hide(event);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Calling this.hide(event) here can cause a runtime error. The event object might not have a client property, for example when show() is called via showById(). The hide() method unconditionally destructures event.client, which will throw an exception if client is undefined.

To fix this, we can conditionally pass the event to hide() only when event.client exists. If it doesn't, calling hide() with undefined will trigger the safe path within the hide method that does not access the client property.

Suggested change
this.hide(event);
this.hide(event.client ? event : undefined);

return;
}

let tooltipContent: { [key: string]: unknown } = {};
if (getContent) {
Expand Down
Loading