Small code cleanup in Tool.java #2756
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace unnecessary generic arguments. Simplify sortGrammarByTokenVocab: parseGrammar returns GrammarRootAST, so it can never return GrammarASTErrorNode Fix typo "no defined" -> "not defined" Remove if branches that are provably unreachable in getOutputDirectory: (fileDirectory is either "." or a prefix of fileNameWithPath)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR
Contributor's Note
I'm creating this pull request mostly to see how open the maintainers are to this type of contribution. I see a lot of bits of this code that could be changed to reduce the cognitive load of the reader, and would like to help improve the code in that way.
If this kind of contribution is unwanted, please let me know and I will not create any more of this type.