fix: accurately locate the suggestion in auto-complete

[divanshu-go]

/claim #420

before

after

@tusharmath I did a PR upstream to solve this issue nushell/reedline#903
You can either wait for them to merge or fork the repo (and then I will do a PR in that fork to resolve this issue)

[CLAassistant]

All committers have signed the CLA.

[tusharmath]

Fantastic! Let's wait for the PR to get merged.

[tusharmath]

How about we create our own CompletionMenu and use that instead of the default one? This way we won't need to wait for the PR to be merged in nushell.

[divanshu-go]

How about we create our own CompletionMenu and use that instead of the default one? This way we won't need to wait for the PR to be merged in nushell.

@tusharmath I suggest that Instead you just fork the repo reedline and I do a PR on that fork
and then use that fork in Cargo.toml

[tusharmath]

Hmm in that case it would be better to maintain just the completion menu. Keeping a fork up to date is quite a painful process.

[divanshu-go]

@tusharmath The Upstream has merged my PR nushell/reedline#903

[divanshu-go]

@tusharmath I have updated the Cargo.toml to use that specific commit from https://github.com/nushell/reedline.git

[divanshu-go]

@tusharmath are there any changes required for this PR ?

[laststylebender14]

@divanshu-go it should highlight the file name only.

[divanshu-go]

@laststylebender14 this is due to find() being used instead of rfind()

the maintainer at reedline insisted on using it for some reason , nushell/reedline#903 (comment)

[divanshu-go]

@laststylebender14

I have did a PR there to solve the problem nushell/reedline#905

[tusharmath]

The search is based on file name, hence selection on the file name would make more sense.

[divanshu-go]

@tusharmath I have did a PR nushell/reedline#905
to solve the problem #650 (comment)

[tusharmath]

@divanshu-go Let me know if you are planning to implement a custom CompletionMenu so that we can format it as per our needs.