Skip to content

fix: Add self._messages to BUILDING_GALLERY section in app initialization #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025

Conversation

klmcadams
Copy link
Collaborator

Add self._messages = None to the BUILDING_GALLERY section of the App initialization so the following AttributeError does not occur when running make -C doc html:

app.messages.show()

if self.messages is not None:
^^^
AttributeError: 'App' object has no attribute '_messages'. Did you mean: 'messages'?

@klmcadams klmcadams requested a review from a team as a code owner May 21, 2025 18:57
@github-actions github-actions bot added the bug Something isn't working label May 21, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label May 21, 2025
@klmcadams klmcadams requested a review from koubaa May 21, 2025 18:59
Copy link

codacy-production bot commented May 21, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.12% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0e72d05) 2537 2191 86.36%
Head commit (b6866da) 2537 (+0) 2194 (+3) 86.48% (+0.12%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1171) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.48%. Comparing base (0e72d05) to head (b6866da).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
+ Coverage   86.36%   86.48%   +0.11%     
==========================================
  Files          39       39              
  Lines        2537     2537              
==========================================
+ Hits         2191     2194       +3     
+ Misses        346      343       -3     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@klmcadams klmcadams requested a review from koubaa May 28, 2025 14:29
@klmcadams klmcadams merged commit a88e0bd into main May 28, 2025
56 checks passed
@klmcadams klmcadams deleted the fix/building-gallery-msgs branch May 28, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants