-
Notifications
You must be signed in to change notification settings - Fork 20
feat: component operations - make_independent() and import_named_selections() #2129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ub.com/ansys/pyansys-geometry into feat/component-independence-and-groups
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2129 +/- ##
=======================================
Coverage 94.19% 94.19%
=======================================
Files 139 139
Lines 10242 10254 +12
=======================================
+ Hits 9647 9659 +12
Misses 595 595 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small suggestions. This PR also made me realize that we missed migrating the ComponentsStub
to the new gRPC architecture. We will have to plan on this too.
Let me know once the comments have been added and I'll reapprove! =)
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Description
Issue linked
Closes #2110 and #2121
Checklist
feat: extrude circle to cylinder
)