Skip to content

feat: component operations - make_independent() and import_named_selections() #2129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 24, 2025

Conversation

jonahrb
Copy link
Contributor

@jonahrb jonahrb commented Jul 23, 2025

Description

  • make components independent from other instances
  • import named selections from inserted components
  • importing named selections on insert_file() now happens by default (server-side change)

Issue linked

Closes #2110 and #2121

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@jonahrb jonahrb requested a review from a team as a code owner July 23, 2025 17:52
@jonahrb jonahrb requested a review from RyanJWard July 23, 2025 17:52
@jonahrb jonahrb self-assigned this Jul 23, 2025
@github-actions github-actions bot added maintenance Package and maintenance related enhancement New features or code improvements labels Jul 23, 2025
@github-actions github-actions bot removed the maintenance Package and maintenance related label Jul 24, 2025
Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.19%. Comparing base (aace701) to head (013dc9e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2129   +/-   ##
=======================================
  Coverage   94.19%   94.19%           
=======================================
  Files         139      139           
  Lines       10242    10254   +12     
=======================================
+ Hits         9647     9659   +12     
  Misses        595      595           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

RobPasMue
RobPasMue previously approved these changes Jul 24, 2025
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small suggestions. This PR also made me realize that we missed migrating the ComponentsStub to the new gRPC architecture. We will have to plan on this too.

Let me know once the comments have been added and I'll reapprove! =)

Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
jonahrb and others added 3 commits July 24, 2025 09:06
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
Co-authored-by: Roberto Pastor Muela <37798125+RobPasMue@users.noreply.github.com>
@jonahrb jonahrb enabled auto-merge (squash) July 24, 2025 14:27
@jonahrb jonahrb linked an issue Jul 24, 2025 that may be closed by this pull request
@jonahrb jonahrb merged commit f9ce7dd into main Jul 24, 2025
75 of 85 checks passed
@jonahrb jonahrb deleted the feat/component-independence-and-groups branch July 24, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make component independent Insert component support for "Import Component Groups"
3 participants