Skip to content

fix: change iterdir() for rglob('*') #2101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

RobPasMue
Copy link
Member

Description

Instead of iterating the top-level of the directory, let's retrieve all files and upload them directly.

Issue linked

Closes #2099

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RobPasMue RobPasMue self-assigned this Jul 11, 2025
@RobPasMue RobPasMue requested a review from a team as a code owner July 11, 2025 06:40
@github-actions github-actions bot added the bug Something isn't working label Jul 11, 2025
@RobPasMue
Copy link
Member Author

@syscordan - could you give it a try whenever you have the chance and see if it fixes your issues reported in #2099 ?

Copy link

codecov bot commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.48%. Comparing base (bfa184d) to head (d8b6a8e).

Files with missing lines Patch % Lines
src/ansys/geometry/core/modeler.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2101      +/-   ##
==========================================
- Coverage   93.50%   93.48%   -0.02%     
==========================================
  Files         138      138              
  Lines       10156    10156              
==========================================
- Hits         9496     9494       -2     
- Misses        660      662       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot open catproduct/SE assemblies if folder same location
2 participants