-
-
Notifications
You must be signed in to change notification settings - Fork 33
🐳 Pin base manylinux containers to 2025.01.19-2 #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
🐳 Pin base manylinux containers to 2025.01.19-2 #697
Conversation
f0a9614
to
798c85e
Compare
Congratulations! One of the builds has completed. 🍾 You can install the built RPMs by following these steps:
Please note that the RPMs should be used only in a testing environment. |
5819341
to
542ab3b
Compare
542ab3b
to
df4c6b6
Compare
YEAR: | ||
VALUE: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Qalthos FYI, I dropped using manylinux1/2010/2014 in favor of PEP 600 since https://github.com/ansible/pylibssh/pull/562/files#diff-7eab675a08c9bdcc37864c516c651215c9f52401564e65c18e201b933c635890.
I assessed they aren't really needed anymore with the modern support matrix + the fact that downstreams would do their own thing anyway.
So you don't really need to worry about those. If we really want to build something with those, we still can use the old images that already exist on GHCR.
Hope this will reduce the number of things that need fixing/checking.
In fact, cibuildwheel
only points to 2_28
so technically even 2_24
might not be necessary, but maybe we should keep building them. Modern enough pip (shipped in supported CPythons) will recognize these tags.
- IMAGE: | ||
ARCH: x86_64 | ||
QEMU_ARCH: amd64 | ||
YEAR: 2010 | ||
YEAR: | ||
VALUE: 2010 | ||
|
||
env: | ||
LIBSSH_VERSION: 0.9.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself: we should eventually read this value from pyproject.toml
or some other centralized location..
@Qalthos I recommend adding |
Yeah I was looking for that but couldn't find it last night. Thanks for the reminder |
|
SUMMARY
SSIA.
ISSUE TYPE
ADDITIONAL INFORMATION
The base manylinux container is currently unpinned, which means that the upstream can break us any time. This is an attempt to pinpoint when that happened.