Move to Runtime Platform Flags #2615
Open
+137
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.9
10 tasks
zkayyali812
force-pushed
the
zk/platform-flags
branch
4 times, most recently
from
8fc3e83 to
767b919
Compare
zkayyali812
force-pushed
the
zk/platform-flags
branch
5 times, most recently
from
6a45156 to
340a741
Compare
zkayyali812
force-pushed
the
zk/platform-flags
branch
from
340a741 to
844c1b9
Compare
zkayyali812
force-pushed
the
zk/platform-flags
branch
from
844c1b9 to
0c26d29
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
Requires the following PR to be merged in first - ansible/django-ansible-base#736
This PR moves the Galaxy feature flag source from Settings based feature flags, to platform database level feature flags.
This also makes gateway the provider of this data for the platform.
This is required to enable platform level feature flags.
Gateway is the provider of the feature flag value updates, and is resource synced to Galaxy/other components.
It can be validated and tested simply with AAP Dev, and requires the following DAB PR to be merged in beforehand -
ansible/django-ansible-base#736
To test -
Clone AAP-Dev
make configure-sources
Select DAB, GW, and Hub for sources
make aap
Attempt to hit <GATEWAY_API>/feature_flags/X api endpoint and patch a flags value.
If Gateway Setting RUNTIME_FEATURE_FLAGS == True, the update succeeds and flag value is resource synced to Hub
If Gateway Setting RUNTIME_FEATURE_FLAGS == False, the update fails with error explaining why.
Issue: AAP-45881
Reviewers must know:
PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit