feat: allow EDA credential fields to link to external Secret Management Systems (SMS) #1349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #1349 +/- ##
==========================================
+ Coverage 93.91% 94.06% +0.14%
==========================================
Files 320 331 +11
Lines 18827 19413 +586
==========================================
+ Hits 17682 18261 +579
- Misses 1145 1152 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
mkanoor
force-pushed
the
external_sms
branch
2 times, most recently
from
e981490 to
0d689a4
Compare
mkanoor
force-pushed
the
external_sms
branch
14 times, most recently
from
6e9c7ba to
0618ffd
Compare
Alex-Izquierdo
previously approved these changes
Jun 19, 2025
hsong-rh
reviewed
Jun 20, 2025
| }, | ||
| description="Run a test on External Credential", | ||
| ) | ||
| @action( |
There was a problem hiding this comment.
Can we move this logic into Mixin to avoid duplicates?
AAP allows text fields in a Credendtial to be connected to an external Secret Management System like Hashicorp Vault. EDA was lacking this feature, this fix tries to address that by providing * Test External SMS for connectivity and existence of secrets * Link text fields to External SMS * Uses the awx-plugins-core to manage the connections to external SMS
|
|
E2E tests pass with the new Openapi.json https://github.com/ansible/eda-qa/actions/runs/15832565070/job/44631584216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AAP allows text fields in a Credential to be connected to an external Secret Management System like Hashicorp Vault.
EDA was lacking this feature, this fix tries to address that by providing
New API end points added
The awx-plugins-core supports 9 different external systems, for parity we have added the schema for all 9 of them
https://issues.redhat.com/browse/AAP-46900
flowchart TD; A[EDA UI] -->|Create Credential| B(EDA API); B --> C{AWX Plugins}; C -->|Fetch/Test| D[fa:fa-vault Hashicorp]; C -->|Fetch/Test| E[fa:fa-vault CyberArk]; C -->|Fetch/Text| F[fa:fa-vault Azure];