fix: de pull fails for images with digest in URI #1347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttuffin
force-pushed
the
AAP-47629_image_digest_pull_fails
branch
from
83b2020 to
ab26a09
Compare
ttuffin
force-pushed
the
AAP-47629_image_digest_pull_fails
branch
from
ab26a09 to
2933d12
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1347 +/- ##
=======================================
Coverage 93.91% 93.91%
=======================================
Files 319 320 +1
Lines 18782 18793 +11
=======================================
+ Hits 17639 17650 +11
Misses 1143 1143
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
ttuffin
commented
Jun 13, 2025
ttuffin
force-pushed
the
AAP-47629_image_digest_pull_fails
branch
3 times, most recently
from
c8b9403 to
5617852
Compare
ttuffin
force-pushed
the
AAP-47629_image_digest_pull_fails
branch
4 times, most recently
from
8eb9e3d to
d16399f
Compare
|
@ttuffin you can refer containers/podman-py#555 |
ttuffin
force-pushed
the
AAP-47629_image_digest_pull_fails
branch
from
d16399f to
6e258ed
Compare
Alex-Izquierdo
previously approved these changes
Jun 13, 2025
DE image pulls will fail when there is a sha digest in the URI. This fix implements a change to the pull logic to split the image URI and pass the repo and tag to podman-py as separate params, as documented.
ttuffin
force-pushed
the
AAP-47629_image_digest_pull_fails
branch
from
6e258ed to
91cfb71
Compare
Alex-Izquierdo
approved these changes
Jun 16, 2025
|
hsong-rh
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DE image pulls will fail when there is a sha digest in the URI. This fix implements a change to the pull logic to split the image URI and pass the repo and tag to podman-py as separate params, as documented in the podman-py docs
Test steps
Create three DE's with the following URI's:
quay.io/ansible/ansible-rulebookquay.io/ansible/ansible-rulebook:mainquay.io:443/ansible/ansible-rulebook@sha256:756dd6a40b62975ea10d83a577ed6b1cddd545de17d9fb56b3d4e80e166826dfCreate three activations using those DE's. All activations should complete
https://issues.redhat.com/browse/AAP-47629