Skip to content

fix: write extra_vars into a file when call ansible-runner #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

bzwei
Copy link
Collaborator

@bzwei bzwei commented Jun 9, 2025

Treat all str values in extra_vars as unsafe. Write them to a yaml file to be consumed by the ansible-runner.

@bzwei bzwei requested a review from a team as a code owner June 9, 2025 18:43
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 91.11111% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.91%. Comparing base (05598a1) to head (f0f3116).

Files with missing lines Patch % Lines
src/aap_eda/services/project/scm.py 33.33% 4 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1343      +/-   ##
==========================================
- Coverage   93.91%   93.91%   -0.01%     
==========================================
  Files         318      319       +1     
  Lines       18741    18780      +39     
==========================================
+ Hits        17601    17637      +36     
- Misses       1140     1143       +3     
Flag Coverage Δ
unit-int-tests-3.11 93.85% <91.11%> (-0.01%) ⬇️
unit-int-tests-3.12 93.91% <91.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/core/utils/safe_yaml.py 100.00% <100.00%> (ø)
tests/unit/test_scm.py 100.00% <ø> (ø)
tests/unit/test_utils.py 100.00% <100.00%> (ø)
src/aap_eda/services/project/scm.py 71.72% <33.33%> (-1.58%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@bzwei bzwei added the run-e2e label Jun 10, 2025
@bzwei bzwei merged commit 2dcbc2e into ansible:main Jun 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants