Skip to content

fix: [AAP-47135] Only return user-input extra_var to the UI #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 5, 2025

Conversation

hsong-rh
Copy link
Contributor

@hsong-rh hsong-rh commented Jun 5, 2025

Remove the extra_var from credential types, and only return user-input ones.

Before:
image
After:
image

https://issues.redhat.com/browse/AAP-47135

@hsong-rh hsong-rh requested a review from a team as a code owner June 5, 2025 15:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (2db001e) to head (531c3a7).

@@            Coverage Diff             @@
##             main    #1340      +/-   ##
==========================================
- Coverage   93.91%   93.91%   -0.01%     
==========================================
  Files         318      318              
  Lines       18742    18741       -1     
==========================================
- Hits        17602    17601       -1     
  Misses       1140     1140              
Flag Coverage Δ
unit-int-tests-3.11 93.85% <100.00%> (-0.01%) ⬇️
unit-int-tests-3.12 93.91% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/aap_eda/api/serializers/activation.py 96.17% <ø> (ø)
...integration/api/test_activation_with_credential.py 100.00% <100.00%> (ø)
...tegration/api/test_activation_with_event_stream.py 96.40% <100.00%> (-0.02%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

sonarqubecloud bot commented Jun 5, 2025

@hsong-rh hsong-rh merged commit e91d392 into ansible:main Jun 5, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants