test: fix flaky tests caused by multithreaded tests #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex <aizquier@redhat.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
- Coverage 94.11% 93.87% -0.25%
==========================================
Files 318 318
Lines 18662 18667 +5
==========================================
- Hits 17564 17523 -41
- Misses 1098 1144 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
ttuffin
approved these changes
Jun 4, 2025
kaiokmo
approved these changes
Jun 4, 2025
|
@Alex-Izquierdo now that #1333 is merged, should we merge this one too? |
Yeah, although there are conflicts to solve. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have sporadic unexpected failures in tests. I think this is caused by
test_job_uniquenesswhich uses multithreading and seems to interfere intermittently with other mocks. Since I could not found a way to avoid it or a better way to do this test (which I think right now is clean and reliable except for the mock interference) I think the best way is to just keep them separately, which is a good and common pattern in general.It marks the test with a new marker "multithreaded" which is never executed by default. Then CI stuff is updated to execute both, default and multithreaded, separately.
Depends on #1333