fix: [AAP-46563] solve potential race condition issue when disabling activations

[hsong-rh]

Move the status update from API to Activation workers to avoid race conditions in activation disabling.

https://issues.redhat.com/browse/AAP-46563

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.11%. Comparing base (50b0bbf) to head (276567f).

Files with missing lines	Patch %	Lines
src/aap_eda/api/views/activation.py	50.00%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #1324      +/-   ##
==========================================
- Coverage   94.11%   94.11%   -0.01%     
==========================================
  Files         318      318              
  Lines       18651    18662      +11     
==========================================
+ Hits        17554    17564      +10     
- Misses       1097     1098       +1     

Flag	Coverage Δ
unit-int-tests-3.11	94.05% <92.85%> (-0.01%)	⬇️
unit-int-tests-3.12	94.11% <92.85%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../aap_eda/services/activation/activation_manager.py	63.25% <ø> (-0.15%)	⬇️
...ts/integration/services/activation/test_manager.py	99.15% <100.00%> (+0.02%)	⬆️
src/aap_eda/api/views/activation.py	97.15% <50.00%> (-0.47%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Alex-Izquierdo]

IMO, is_enabled should not be domain of the activation_manager because it is a property of the activation as template, not part of the lifecycle of the activation. is_enabled triggers the stop operation, that's all.

Without reading it in deep, this change seems a stronger change and it might be the cause of the failed e2e tests.

I think the fix is much more simpler and It is what I understood it would be from our previous conversation. In the view we set activation.status = ActivationStatus.STOPPING only when the activation is already running (starting or running status). No need of migrations or changing the manager/orchestrator which already has the right logic.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud