Skip to content

feat: [AAP-46254] trigger project resync after project update #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

kaiokmo
Copy link
Member

@kaiokmo kaiokmo commented Jun 2, 2025

This commit causes auto sync/import of a project when one of its url, scm_branch, or scm_refspec is updated,
without the user having to manually trigger the sync via the UI/API.

https://issues.redhat.com/browse/AAP-46254

@kaiokmo kaiokmo requested a review from a team as a code owner June 2, 2025 17:44
@kaiokmo kaiokmo added enhancement New feature or request run-e2e labels Jun 2, 2025
@kaiokmo kaiokmo force-pushed the AAP-46254 branch 2 times, most recently from 183e8ed to a54107e Compare June 2, 2025 17:50
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.91%. Comparing base (72db4ce) to head (faa1040).

Files with missing lines Patch % Lines
src/aap_eda/api/views/project.py 81.81% 2 Missing ⚠️
@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         320      320           
  Lines       18793    18827   +34     
=======================================
+ Hits        17650    17682   +32     
- Misses       1143     1145    +2     
Flag Coverage Δ
unit-int-tests-3.11 93.85% <94.11%> (+<0.01%) ⬆️
unit-int-tests-3.12 93.91% <94.11%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
tests/integration/api/test_project.py 99.47% <100.00%> (+0.03%) ⬆️
src/aap_eda/api/views/project.py 95.32% <81.81%> (-1.55%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kaiokmo kaiokmo force-pushed the AAP-46254 branch 2 times, most recently from 2fe4287 to 44608a8 Compare June 9, 2025 21:03
@kaiokmo kaiokmo force-pushed the AAP-46254 branch 2 times, most recently from eba52e2 to fa16e84 Compare June 10, 2025 19:59
This commit causes auto sync/import of a project when one of its
url or scm_branch/tag/commit is updated, without the user having
to manually trigger the sync via the UI/API.
@kaiokmo
Copy link
Member Author

kaiokmo commented Jun 17, 2025

successful test run: https://github.com/ansible/eda-server/actions/runs/15695197469

had to trigger it manually between branches eda-server/AAP-46254 and eda-qa/fix-project-resync because of chicken-egg problem

Copy link

@kaiokmo kaiokmo merged commit f82dabc into ansible:main Jun 17, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request run-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants