Skip to content

fix: update docker network for UI e2e tests workflow #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2024
Merged

fix: update docker network for UI e2e tests workflow #1004

merged 2 commits into from
Aug 13, 2024

Conversation

Dostonbek1
Copy link
Member

No description provided.

@Dostonbek1 Dostonbek1 requested a review from a team as a code owner August 13, 2024 16:41
zkayyali812
zkayyali812 reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@zkayyali812 zkayyali812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we add -

on:
  workflow_dispatch:

to the triggers for this as well, in case we need to test this out more thoroughly in a branch.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Dostonbek1
Copy link
Member Author

I recommend we add -

on:
  workflow_dispatch:

to the triggers for this as well, in case we need to test this out more thoroughly in a branch.

Added.

@Dostonbek1 Dostonbek1 requested a review from zkayyali812 August 13, 2024 16:51
zkayyali812
zkayyali812 approved these changes Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@zkayyali812 zkayyali812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Dostonbek1 Dostonbek1 merged commit a3419c7 into ansible:main Aug 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msmagnanijr msmagnanijr msmagnanijr approved these changes

@zkayyali812 zkayyali812 zkayyali812 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dostonbek1 @msmagnanijr @zkayyali812