fix: check for valid settings before creating EventStreams #1001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkanoor
force-pushed
the
aap_29132
branch
4 times, most recently
from
a5ceb29 to
3c324e6
Compare
Dostonbek1
reviewed
Aug 13, 2024
Dostonbek1
approved these changes
Aug 13, 2024
JIRA: https://issues.redhat.com/browse/AAP-29132 Before we create event streams we have to check the settings are proper. If the EDA_WEBHOOK_MTLS_BASE_URL is missing we should not allow users to create event streams that use mTLS webhook.
msmagnanijr
approved these changes
Aug 13, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/AAP-29132
Before we create event streams we have to check the settings are proper.
If the EDA_WEBHOOK_BASE_URL is missing we should not allow users to create event streams that use non mTLS webhooks.
If the EDA_WEBHOOK_MTLS_BASE_URL is missing we should not allow users to create event streams that use mTLS webhook.