Define PTP model for the Dell Enterprise SONiC collection #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArunSaravananBalachandran
suggested changes
Apr 10, 2025
Comment on lines
30
to
31
| - the priority1 attribute of the local clock. | ||
| - the range is from 0 to 255. |
There was a problem hiding this comment.
Suggested change
| - the priority1 attribute of the local clock. | |
| - the range is from 0 to 255. | |
| - The priority1 attribute of the local clock. | |
| - The range is from 0 to 255. |
Comment on lines
35
to
36
| - the priority2 attribute of the local clock. | ||
| - the range is from 0 to 255. |
There was a problem hiding this comment.
Suggested change
| - the priority2 attribute of the local clock. | |
| - the range is from 0 to 255. | |
| - The priority2 attribute of the local clock. | |
| - The range is from 0 to 255. |
Comment on lines
71
to
72
| - Defines the type of clock configured in the PTP domain. | ||
| - The possible values are (BC)|(P2P_TC)|(E2E_TC)|(disable) |
There was a problem hiding this comment.
Suggested change
| - Defines the type of clock configured in the PTP domain. | |
| - The possible values are (BC)|(P2P_TC)|(E2E_TC)|(disable) | |
| - Specifies the type of clock configured in the PTP domain. |
Comment on lines
77
to
78
| - The network transport used for communication | ||
| - The permitted values are (L2)|(UDPv4)|(UDPv6) |
There was a problem hiding this comment.
Suggested change
| - The network transport used for communication | |
| - The permitted values are (L2)|(UDPv4)|(UDPv6) | |
| - The network transport used for communication. |
Comment on lines
83
to
85
| - Whether the network transport uses unicast or | ||
| - multicast communication | ||
| - The permitted values are (unicast)|(multicast) |
There was a problem hiding this comment.
Suggested change
| - Whether the network transport uses unicast or | |
| - multicast communication | |
| - The permitted values are (unicast)|(multicast) | |
| - Specifies whether the network transport uses unicast or multicast communication. |
| - interface: 'ethernet0' | ||
| role: 'slave' | ||
| localpriority: 100 | ||
| unicasttable: ['1.1.1.1'] |
There was a problem hiding this comment.
Suggested change
| unicasttable: ['1.1.1.1'] | |
| unicasttable: | |
| - '1.1.1.1' |
There was a problem hiding this comment.
will address this like unicasttable: ["1.1.1.1" , "1.1.1.2"]
| config: | ||
| - interface : 'Ethernet0' | ||
| role: 'slave' | ||
| unicasttable: ['1.1.1.1'] |
There was a problem hiding this comment.
Suggested change
| unicasttable: ['1.1.1.1'] | |
| unicasttable: | |
| - '1.1.1.1' |
| # sonic# | ||
|
|
||
| - name: Delete specified PTP configurations | ||
| dellemc.enterprise_sonic.sonic_ptp: |
There was a problem hiding this comment.
Suggested change
| dellemc.enterprise_sonic.sonic_ptp: | |
| dellemc.enterprise_sonic.sonic_ptp_port_ds: |
| # sonic# | ||
|
|
||
| - name: Delete specified PTP configurations | ||
| dellemc.enterprise_sonic.sonic_ptp: |
There was a problem hiding this comment.
Suggested change
| dellemc.enterprise_sonic.sonic_ptp: | |
| dellemc.enterprise_sonic.sonic_ptp_port_ds: |
Comment on lines
23
to
24
| priority1 101 | ||
| priority2 91 |
There was a problem hiding this comment.
Suggested change
| priority1 101 | |
| priority2 91 | |
| priority1: 101 | |
| priority2: 91 |
|
Have addressed the Review comments |
Open
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial posting of model definition for PTP ansible changes