-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add SelectionModeToggle component for model comparison and expo… #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rt functionality - Introduced a new SelectionModeToggle component to allow users to switch between comparison and export modes. - Enhanced user experience with tooltips providing context for each mode. - Updated TableHeadCell and FilterSubject components for improved styling and type definitions.
…ata table - Removed redundant cursor pointer styles from index.css to streamline CSS. - Added a new TableConfig type definition to enhance type safety and configuration options for the data table. - Updated data-export and toolbar components to utilize the new TableConfig type, improving code organization and maintainability.
- Added a new Selection Mode Toggle feature allowing users to switch between comparison (max 10 items) and export (unlimited items) modes. - Enhanced selection logic to ensure proper handling of selection limits and reactivity to mode changes. - Updated DataTable and related components to support the new selection modes, improving user experience and functionality. - Fixed various issues related to selection handling and ensured backward compatibility with existing features.
…onents - Standardized formatting in RegularTable and VirtualTable components by aligning JSX attributes and removing unnecessary line breaks. - Enhanced readability in use-table hook by restructuring return statements and callback functions. - Improved overall code organization and maintainability across data table components.
…actions - Added a new DataTableActionBar component to provide a toolbar for actions related to selected rows in the data table. - Implemented functionality for clearing row selections and displaying the count of selected rows. - Integrated animations and tooltips for improved user experience and accessibility. - Ensured compatibility with existing table functionalities and improved overall interaction design.
- Introduced several new components for the data table, including SelectionModeToggle, DataTableFilter, and various UI elements for improved user interaction. - Implemented a new filtering system with customizable filter actions and operators, enhancing data manipulation capabilities. - Refactored existing components for better organization and maintainability, including updates to the toolbar and pagination features. - Improved overall user experience with tooltips and debounced input for filter fields, ensuring responsive and intuitive interactions. - Removed deprecated components and streamlined code for better performance and readability.
- Introduced the highlight-words package to support text highlighting functionality within the data table. - Added new test utilities and components for improved testing of data table features. - Enhanced existing data table components with better type definitions and improved structure for maintainability. - Updated various components to ensure compatibility with the new highlighting feature and improved user experience.
…d type refinements - Added a new localization key for showing columns in the data table. - Updated tooltip texts in various buttons to utilize localization for better user experience. - Refactored button props to use more specific type definitions for improved type safety. - Streamlined code in several components for better maintainability and readability.
…, and improved component structure - Updated column IDs to use the "ano-" prefix for consistency. - Added new localization keys for reset actions and improved existing ones for better user experience. - Refactored components to include new TypeScript types and improved memoization for performance. - Enhanced scrolling behavior and added debug listeners for better diagnostics. - Cleaned up unused props and ensured proper handling of table references for better maintainability.
- Modified the development script in package.json to remove the explicit port setting, allowing Vite to use the default port for development.
✅ Deploy Preview for ai-models-table ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Caution Review failedThe pull request is closed. WalkthroughThis PR removes legacy components, updates docs, revises package scripts/deps, and introduces a new, modular Data Table system (head/body/footer, buttons, virtualization, pinning, resizing, filtering, sorting) with extensive unit tests. It also adjusts an export in data-table-filter and adds migration/refactor documentation. Changes
Sequence Diagram(s)sequenceDiagram
participant App
participant DataTable
participant useDataTable
participant TablePaper
participant Head
participant Body
participant Footer
participant Buttons
App->>DataTable: props (table instance | options)
alt Provided TableInstance
DataTable->>TablePaper: table, features
else Options provided
DataTable->>useDataTable: options
useDataTable-->>DataTable: table, features
DataTable->>TablePaper: table, features
end
TablePaper->>Head: render (sorting/filtering/drag/resize)
TablePaper->>Body: render (rows, virtualization, pinning, detail)
TablePaper->>Footer: render (footer groups/virtualization)
App->>Buttons: user actions (e.g., ExpandAll, ToggleFilters)
Buttons->>table: update state (expand, filter, density, fullscreen)
table-->>Head: re-render
table-->>Body: re-render
table-->>Footer: re-render
Estimated code review effort🎯 5 (Critical) | ⏱️ ~90 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Thank you for following the naming conventions! 🙏 |
🚂 You're on fire, @prisis! Three PRs merged and counting! 🔥🎉 Your consistent contributions are truly impressive. You're becoming a valued member of our community! 💖 Remember, @prisis is always here to support you. Keep blazing that trail! 🚀 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
…rt functionality
Summary by CodeRabbit