Skip to content

ci: ignore yarn & bazel updates #2784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025
Merged

Conversation

alan-agius4
Copy link
Collaborator

yarn is copied locally

@alan-agius4 alan-agius4 requested a review from devversion May 12, 2025 09:04
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 12, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 12, 2025
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project labels May 12, 2025
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 12, 2025
@alan-agius4 alan-agius4 changed the title ci: ignore yarn updates ci: ignore yarn & bazel updates May 12, 2025
@alan-agius4 alan-agius4 removed the action: merge The PR is ready for merge by the caretaker label May 12, 2025
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label May 12, 2025
@alan-agius4 alan-agius4 force-pushed the yarn-ignore branch 3 times, most recently from d764053 to 2d4503e Compare May 12, 2025 10:32
@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented May 12, 2025

Do not merge this yet as I want to reformat.

- `yarn` is copied locally
- `bazel` major version should not be updated
Here's a breakdown of their preferences:

* **`matchDepNames` is generally preferred for clarity and accuracy.**
    * `matchDepNames` was introduced specifically to match against the `depName` field, which typically represents the "short" or primary name of a dependency (e.g., `react`, `lodash`).
    * Using `matchDepNames` makes your Renovate configuration more explicit and easier to understand, as its name directly reflects its intended behavior.

* **`matchPackageNames` has historical baggage and can be misleading.**
    * Historically, `matchPackageNames` in Renovate also matched against the `depName` by default, despite its name suggesting it would match the `packageName` field. This was due to an earlier implementation decision.
    * While `matchPackageNames` might still match `depName` in many current setups (for backward compatibility), it can be confusing and lead to unexpected behavior if you're expecting it to match the `packageName` (which is often a more complete or specific identifier, like `org.apache.maven:maven-core`).
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 12, 2025
@devversion devversion merged commit fdf5843 into angular:main May 12, 2025
8 checks passed
@alan-agius4 alan-agius4 deleted the yarn-ignore branch May 12, 2025 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants