Skip to content

feat(ng-dev): create pr takeover command #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

josephperrott
Copy link
Member

Create a command that allows for a user to checkout and takeover a pull request from github-robot. The process creates a local copy of the pull request and updates the commit messages to include its merge closing the original pull request.

@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Apr 10, 2024
@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Apr 10, 2024
Create a command that allows for a user to checkout and takeover a pull request from github-robot. The process
creates a local copy of the pull request and updates the commit messages to include its merge closing the original
pull request.
@josephperrott josephperrott force-pushed the takeover-pr branch 2 times, most recently from 91b792f to f5c179a Compare April 17, 2024 17:45
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looks great! love the allowMaintainerEdits = false

@josephperrott
Copy link
Member Author

This PR was merged into the repository by commit ac16464.

@josephperrott josephperrott deleted the takeover-pr branch April 17, 2024 18:21
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker detected: feature PR contains a feature commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants