Skip to content

feat(material/schematics): Add custom system variable prefix and high contrast override mixins options to custom theme schematic #29607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

amysorto
Copy link
Contributor

No description provided.

@angular-robot angular-robot bot added the detected: feature PR contains a feature commit label Aug 19, 2024
… contrast override mixins options to custom theme schematic
@amysorto amysorto force-pushed the high-contrast-schematic branch from 971550d to a715a38 Compare August 21, 2024 16:05
@amysorto amysorto added Accessibility This issue is related to accessibility (a11y) area: theming target: minor This PR is targeted for the next minor release labels Aug 21, 2024
@amysorto amysorto marked this pull request as ready for review August 21, 2024 16:14
@amysorto amysorto requested a review from a team as a code owner August 21, 2024 16:14
@amysorto amysorto requested review from crisbeto, wagnermaciel and andrewseguin and removed request for a team August 21, 2024 16:14
*
* This is a TypeScript port of the logic in `core/theming/_palettes.scss#_patch-missing-hues`.
*/
function patchMissingHues(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we accounting for these missing hues now or did the module get fixed so it generates everything now? If that's the case, we may want to update src/material/core/theming/_palettes.scss which was doing similar patching.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things get generated correctly now, it has those missing tones that we usually add from this patching when the theme gets generated.

I can update that file with the missing values in a separate PR so we don't have to patch anymore for our predefined palettes.

@amysorto
Copy link
Contributor Author

Closing this PR to make a different one that relies on the theme() instead of define-theme()

@amysorto amysorto closed this Aug 23, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) area: theming detected: feature PR contains a feature commit target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants