This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Add attr (tagging-equals) to set a property for equality in custom objects (tagging) #1939
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgaggino Thanks for submitting this PR. I think this could be something for the futher. For now the focus of this repo is to get less bugs and less new enhancements. Still i'm curious could you share a working plunker with some custom functions for this? |
|
Hi @Jefiozie thanks for replying, I'll be adding the tests and the plunker as soon as possible Kind regards! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you supply a function for tagging, the new item is compared with the existing ones by angular.equals. This is good for primitives but when you are using custom objects they may not be equals due to one ore more properties.
The idea here is to add a new directive attribute (tagging-equals) to set a property by witch the custom object will be compared.