Skip to content

initiate streams package #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

flokli
Copy link

@flokli flokli commented May 23, 2025

This contains definitions for all message types present in "JSON stream" messages, produced by the gerrit stream-events command, or the webhook plugin.

As per the discussion in
#187 (comment), this is put in a separate package to avoid clashes with other types.

Closes #187.

This contains definitions for all message types present in "JSON stream"
messages, produced by the `gerrit stream-events` command, or the webhook
plugin.

As per the discussion in
andygrunwald#187 (comment),
this is put in a separate package to avoid clashes with other types.

Closes andygrunwald#187.
@flokli flokli mentioned this pull request May 24, 2025
@flokli
Copy link
Author

flokli commented Jun 27, 2025

Poke @andygrunwald ;-)

domenkozar pushed a commit to cachix/snix that referenced this pull request Jul 1, 2025
The types are different for `gerrit stream-events` and webhooks, so
switch to a fork of go-gerrit containing their definitions.

andygrunwald/go-gerrit#189 is the upstream PR.
Change-Id: I24136af2f2cf5655f2a8278632a3b0f52aa6adcc
Reviewed-on: https://cl.snix.dev/c/snix/+/30544
Autosubmit: Florian Klink <flokli@flokli.de>
Tested-by: besadii
Reviewed-by: Ilan Joselevich <personal@ilanjoselevich.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant