-
Notifications
You must be signed in to change notification settings - Fork 5k
🤖 Update Dependencies #1554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
🤖 Update Dependencies #1554
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @compose-devrel-github-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates dependencies across multiple modules (JetLagged, JetNews, Jetcaster, Jetchat, Jetsnack, Reply, and scripts). The primary change involves updating versions in the libs.versions.toml
files for each module, as well as adding init.gradle.kts files for spotless formatting. These updates include libraries like Accompanist, Android Gradle Plugin, AndroidX libraries, Kotlin Coroutines, Hilt, Horologist, Robolectric, Room, and more. The spotless plugin is also configured to enforce code style and license headers.
Highlights
- Dependency Updates: The pull request updates a wide range of dependencies to their latest versions, ensuring compatibility and access to the newest features and bug fixes.
- Spotless Integration: The pull request introduces Spotless, a code formatter, to maintain consistent code style across all projects.
- Kotlin Version Upgrade: The pull request upgrades the Kotlin version to 2.1.20, leveraging the latest language features and improvements.
- Android Gradle Plugin Update: The pull request updates the Android Gradle Plugin to version 8.9.2, ensuring compatibility with the latest Android SDK and build tools.
- Compose BOM Update: The pull request updates the Compose BOM to version 2025.04.01, providing a managed set of Compose dependencies.
Changelog
Click here to see the changelog
- JetLagged/buildscripts/init.gradle.kts
- Added init.gradle.kts to configure Spotless plugin for code formatting and license header enforcement.
- JetLagged/gradle/libs.versions.toml
- Updated accompanist version to 0.37.2.
- Added android-material3 version 1.13.0-alpha13.
- Updated androidGradlePlugin version to 8.9.2.
- Updated androidx-activity-compose version to 1.10.1.
- Updated androidx-compose-bom version to 2025.04.01.
- Updated androidx-corektx version to 1.16.0.
- Updated androidx-navigation version to 2.8.9.
- Updated coroutines version to 1.10.2.
- Updated hilt version to 2.56.2.
- Updated horologist version to 0.6.23.
- Updated kotlin version to 2.1.20.
- Updated ksp version to 2.1.20-2.0.0.
- Updated roborazzi version to 1.43.1.
- Updated room version to 2.7.1.
- Updated version-catalog-update version to 1.0.0.
- JetNews/buildscripts/init.gradle.kts
- Added init.gradle.kts to configure Spotless plugin for code formatting and license header enforcement.
- JetNews/gradle/libs.versions.toml
- Updated accompanist version to 0.37.2.
- Added android-material3 version 1.13.0-alpha13.
- Updated androidGradlePlugin version to 8.9.2.
- Updated androidx-activity-compose version to 1.10.1.
- Updated androidx-compose-bom version to 2025.04.01.
- Updated androidx-corektx version to 1.16.0.
- Updated androidx-navigation version to 2.8.9.
- Updated coroutines version to 1.10.2.
- Updated hilt version to 2.56.2.
- Updated horologist version to 0.6.23.
- Updated kotlin version to 2.1.20.
- Updated ksp version to 2.1.20-2.0.0.
- Updated roborazzi version to 1.43.1.
- Updated room version to 2.7.1.
- Updated version-catalog-update version to 1.0.0.
- Jetcaster/buildscripts/init.gradle.kts
- Added init.gradle.kts to configure Spotless plugin for code formatting and license header enforcement.
- Jetcaster/gradle/libs.versions.toml
- Updated accompanist version to 0.37.2.
- Added android-material3 version to 1.13.0-alpha13.
- Updated androidGradlePlugin version to 8.9.2.
- Updated androidx-activity-compose version to 1.10.1.
- Updated androidx-compose-bom version to 2025.04.01.
- Updated androidx-corektx version to 1.16.0.
- Updated androidx-navigation version to 2.8.9.
- Updated coroutines version to 1.10.2.
- Updated hilt version to 2.56.2.
- Updated horologist version to 0.6.23.
- Updated kotlin version to 2.1.20.
- Updated ksp version to 2.1.20-2.0.0.
- Updated roborazzi version to 1.43.1.
- Updated room version to 2.7.1.
- Updated version-catalog-update version to 1.0.0.
- Removed duplicate android-material3 entry under libraries and versions.
- Jetchat/buildscripts/init.gradle.kts
- Added init.gradle.kts to configure Spotless plugin for code formatting and license header enforcement.
- Jetchat/gradle/libs.versions.toml
- Updated accompanist version to 0.37.2.
- Added android-material3 version 1.13.0-alpha13.
- Updated androidGradlePlugin version to 8.9.2.
- Updated androidx-activity-compose version to 1.10.1.
- Updated androidx-compose-bom version to 2025.04.01.
- Updated androidx-corektx version to 1.16.0.
- Updated androidx-navigation version to 2.8.9.
- Updated coroutines version to 1.10.2.
- Updated hilt version to 2.56.2.
- Updated horologist version to 0.6.23.
- Updated kotlin version to 2.1.20.
- Updated ksp version to 2.1.20-2.0.0.
- Updated roborazzi version to 1.43.1.
- Updated room version to 2.7.1.
- Updated version-catalog-update version to 1.0.0.
- Jetsnack/buildscripts/init.gradle.kts
- Added init.gradle.kts to configure Spotless plugin for code formatting and license header enforcement.
- Jetsnack/gradle/libs.versions.toml
- Updated accompanist version to 0.37.2.
- Added android-material3 version 1.13.0-alpha13.
- Updated androidGradlePlugin version to 8.9.2.
- Updated androidx-activity-compose version to 1.10.1.
- Updated androidx-compose-bom version to 2025.04.01.
- Updated androidx-corektx version to 1.16.0.
- Updated androidx-navigation version to 2.8.9.
- Updated coroutines version to 1.10.2.
- Updated hilt version to 2.56.2.
- Updated horologist version to 0.6.23.
- Updated kotlin version to 2.1.20.
- Updated ksp version to 2.1.20-2.0.0.
- Updated roborazzi version to 1.43.1.
- Updated room version to 2.7.1.
- Updated version-catalog-update version to 1.0.0.
- Reply/buildscripts/init.gradle.kts
- Added init.gradle.kts to configure Spotless plugin for code formatting and license header enforcement.
- Reply/gradle/libs.versions.toml
- Updated accompanist version to 0.37.2.
- Added android-material3 version 1.13.0-alpha13.
- Updated androidGradlePlugin version to 8.9.2.
- Updated androidx-activity-compose version to 1.10.1.
- Updated androidx-compose-bom version to 2025.04.01.
- Updated androidx-corektx version to 1.16.0.
- Updated androidx-navigation version to 2.8.9.
- Updated coroutines version to 1.10.2.
- Updated hilt version to 2.56.2.
- Updated horologist version to 0.6.23.
- Updated kotlin version to 2.1.20.
- Updated ksp version to 2.1.20-2.0.0.
- Updated roborazzi version to 1.43.1.
- Updated room version to 2.7.1.
- Updated version-catalog-update version to 1.0.0.
- scripts/libs.versions.toml
- Updated accompanist version to 0.37.2.
- Added android-material3 version 1.13.0-alpha13.
- Updated androidGradlePlugin version to 8.9.2.
- Updated androidx-activity-compose version to 1.10.1.
- Updated androidx-compose-bom version to 2025.04.01.
- Updated androidx-corektx version to 1.16.0.
- Updated androidx-navigation version to 2.8.9.
- Updated coroutines version to 1.10.2.
- Updated hilt version to 2.56.2.
- Updated horologist version to 0.6.23.
- Updated kotlin version to 2.1.20.
- Updated ksp version to 2.1.20-2.0.0.
- Updated roborazzi version to 1.43.1.
- Updated room version to 2.7.1.
- Updated version-catalog-update version to 1.0.0.
- Added spotless plugin and id.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A catalog of versions,
Keeps our dependencies in line.
Spotless cleans our code,
A consistent design.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request updates dependencies across multiple Android projects. The changes include updates to Gradle plugins, Kotlin versions, Compose BOM, and other libraries. The addition of spotless plugin to multiple projects is a good step towards code quality. Overall, the changes seem beneficial, but let's take a closer look.
Summary of Findings
- Dependency Updates: Several dependencies have been updated, including Accompanist, Android Gradle Plugin, Compose BOM, Kotlin, Hilt, and others. It's important to ensure these updates are compatible with the existing codebase and don't introduce any regressions.
- Spotless Plugin Integration: The spotless plugin has been added to multiple projects. This will help enforce code style and formatting. Ensure that the configuration is consistent across all projects.
- Android Material 3 Alpha Version: The pull request introduces a dependency on an alpha version of Android Material 3. While it's fine to use alpha versions for testing and experimentation, it's generally not recommended for production code due to potential instability and breaking changes.
Merge Readiness
The pull request updates dependencies and integrates the spotless plugin. Before merging, it's crucial to verify that all dependency updates are compatible and don't introduce regressions. The use of an alpha version of Android Material 3 should be carefully considered. I am unable to approve this pull request, and recommend that others review and approve this code before merging. At a minimum, the high severity issues should be addressed before merging.
androidGradlePlugin = "8.8.1" | ||
androidx-activity-compose = "1.10.0" | ||
accompanist = "0.37.2" | ||
android-material3 = "1.13.0-alpha13" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated depedencies