-
Notifications
You must be signed in to change notification settings - Fork 5k
Update gradle-wrapper.properties #1553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
made gradle property read value from locally downloaded gradle
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @oxcodemojo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request updates the gradle-wrapper.properties
file to change the distribution URL for Gradle. Instead of downloading Gradle from the official Gradle distribution server, it now points to a local file on the user's desktop. The stated intent is to read the Gradle property value from a locally downloaded Gradle distribution.
Highlights
- Gradle Distribution URL: The
distributionUrl
property ingradle-wrapper.properties
has been modified to point to a local file path instead of the official Gradle distribution URL.
Changelog
- Reply/gradle/wrapper/gradle-wrapper.properties
- Modified the
distributionUrl
property to point tofile:///C:/Users/USER/OneDrive/Desktop/gradle-8.11.1-bin.zip
instead ofhttps\://services.gradle.org/distributions/gradle-8.10.2-bin.zip
.
- Modified the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A local Gradle,
A desktop's hidden treasure,
Builds now commence.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request modifies the gradle-wrapper.properties
file to point to a local Gradle distribution. While this might be useful for local development or testing, it's generally not recommended for shared projects due to portability and reproducibility concerns.
Summary of Findings
- Local File Dependency: The change introduces a dependency on a local file for the Gradle distribution. This approach is not recommended for team projects as it relies on a specific file path on a developer's machine, making the build non-reproducible across different environments. It is recommended to use a standard, publicly available Gradle distribution URL.
Merge Readiness
The pull request introduces a change that makes the build dependent on a local file, which is not recommended for team projects. I recommend reverting this change to use a standard, publicly available Gradle distribution URL. I am unable to approve the pull request in any circumstance, and that users should have others review and approve this code before merging.
@@ -14,6 +14,6 @@ | |||
|
|||
distributionBase=GRADLE_USER_HOME | |||
distributionPath=wrapper/dists | |||
distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-bin.zip | |||
distributionUrl=file:///C:/Users/USER/OneDrive/Desktop/gradle-8.11.1-bin.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using a local file path for the Gradle distribution URL makes the build dependent on a specific environment and is not recommended for team projects. It's better to use a standard, publicly available Gradle distribution URL to ensure reproducibility across different environments.
Consider reverting this change to use a URL like https://services.gradle.org/distributions/gradle-8.11.1-bin.zip
or similar.
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip
made gradle property read value from locally downloaded gradle