Skip to content

Add triggers to .github/workflows/ #613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

cartland
Copy link

@cartland cartland commented May 5, 2025

This PR standardizes GitHub Actions triggers in workflow files within .github/workflows/.

The goal is to ensure workflows run consistently on push, pull_request, and workflow_dispatch events where appropriate.

This is part of a batch of pull requests across repositories owned by the android organization on GitHub.

Project Owner: Please review the changes carefully to ensure they are correct and appropriate for this project before approving and merging.

  • If you do not think this change is appropriate (e.g., a workflow should NOT run on one of these triggers), please leave a comment explaining why.
  • If you think the goal is appropriate but notice a mistake in the implementation, please leave a comment detailing the mistake.

Copy link

Note

The files in this pull request are not supported by Gemini Code Assist.

@cartland
Copy link
Author

cartland commented May 5, 2025

CI is not working on this repository, likely due to this issue:

The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest), or ubuntu-22.04 instead. For more details see actions/runner-images#6002

I will try to update the environment to ubuntu-20.04.

Fixes this error: The ubuntu-18.04 environment is deprecated, consider switching to ubuntu-20.04(ubuntu-latest),
or ubuntu-22.04 instead. For more details see actions/runner-images#6002
@cartland cartland closed this May 5, 2025
@cartland cartland reopened this May 5, 2025
Responding to error: "This is a scheduled Ubuntu 20.04 retirement.
Ubuntu 20.04 LTS runner will be removed on 2025-04-15.
For more details, see actions/runner-images#11101""
@cartland
Copy link
Author

cartland commented May 5, 2025

ubuntu-20.04 also has a deprecation plan. Switching to ubuntu-latest so that we need to do fewer updates on our end. Since we're required to update so often, CI will probably be more stable with latest than a specific version number.

cartland added 3 commits May 5, 2025 15:11
The builds are failing:
* Error: Missing download info for actions/upload-artifact@v1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant