-
Notifications
You must be signed in to change notification settings - Fork 126
ada4355: add linux support #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Test Results1 715 tests +1 462 ✅ ±0 12m 3s ⏱️ -1s Results for commit 4f448e2. ± Comparison against base commit b89168a. This pull request removes 4 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
c893d3b to
87f83be
Compare
adi/ada4355.py
Outdated
| @property | ||
| def test_mode(self): | ||
| """Get test mode register value (0x0D)""" | ||
| return int(self.ada4355_register_read(0x0D), 0) # returns integer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this not part of the driver? We rarely add register specific attributes as they point out deficiencies in the drivers. This returns are value as well, so how do we know what it means? If this doesn't get into the driver it needs to be at least documented what the return (and written) values can be
| class _channel(attribute): | ||
| """ ada4355 channel """ | ||
|
|
||
| def __init__(self, ctrl, channel_name): | ||
| self.name = channel_name | ||
| self._ctrl = ctrl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this code?
tfcollins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments
87f83be to
aca9204
Compare
Add ada4355 pyadi-iio support for the linux driver. https://github.com/analogdevicesinc/linux/blob/34bb38377c9daa30d2abc632b82b4b654a32e90b/drivers/iio/adc/ada4355.c Signed-off-by: Pop Ioan Daniel <pop.ioan-daniel@analog.com>
aca9204 to
4f448e2
Compare
|
V2:
|
|
Generated documentation for this PR is available at Link |
Add ada4355 pyadi-iio support for the linux driver.
https://github.com/analogdevicesinc/linux/blob/34bb38377c9daa30d2abc632b82b4b654a32e90b/drivers/iio/adc/ada4355.c
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: