-
Notifications
You must be signed in to change notification settings - Fork 126
adi:ad405x: Add support for AD4060/62 #672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
91d36b8 to
b269cb0
Compare
gastmaier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved but we need to wait analogdevicesinc/no-OS#2665
to be merged first.
| "attr, val", | ||
| [ | ||
| ("sampling_frequency", [10000, 50000, 100000, 200000, 500000, 1000000],), | ||
| ("operating_mode", ["config_mode", "adc_mode"],), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are removing an attribute from the test. Your commits don't reference why
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the commit in Rev1
1cc5dce to
63a7c61
Compare
Rev1
|
gastmaier
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The removal of operation_mode makes sense since the updated driver does into and out modes depending on the set IIO parameters and calls
|
The Linux Test failures are unrelated to this PR and points to adi/ad719x.py |
1. Added support for AD4060 and AD4062 as new generics of AD405x. 2. The mode configuration has been removed from configuration since AD4060 and AD4062 do not have a config mode. Signed-off-by: Swaroop PrakashKumar <Swaroop.PrakashKumar@analog.com>
63a7c61 to
5e909f8
Compare
Description
Add support for AD4060 and AD4062.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: