Skip to content

Conversation

@SwaroopPKADI
Copy link

@SwaroopPKADI SwaroopPKADI commented Jul 11, 2025

Description

Add support for AD4060 and AD4062.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Hardware: EVAL-AD4060 + Nucleo-H563, EVAL-AD4062 + Nucleo-H563
  • OS: Windows

Documentation

If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have signed off all commits and they contain "Signed-off by: "
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but we need to wait analogdevicesinc/no-OS#2665
to be merged first.

"attr, val",
[
("sampling_frequency", [10000, 50000, 100000, 200000, 500000, 1000000],),
("operating_mode", ["config_mode", "adc_mode"],),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are removing an attribute from the test. Your commits don't reference why

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the commit in Rev1

@SwaroopPKADI SwaroopPKADI force-pushed the ad405x/6x_dev branch 2 times, most recently from 1cc5dce to 63a7c61 Compare August 15, 2025 16:40
@SwaroopPKADI
Copy link
Author

Rev1

  1. Added commit description describing the changes.

Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of operation_mode makes sense since the updated driver does into and out modes depending on the set IIO parameters and calls

@SwaroopPKADI
Copy link
Author

The Linux Test failures are unrelated to this PR and points to adi/ad719x.py

1. Added support for AD4060 and AD4062 as new generics of AD405x.
2. The mode configuration has been removed from configuration since
   AD4060 and AD4062 do not have a config mode.

Signed-off-by: Swaroop PrakashKumar <Swaroop.PrakashKumar@analog.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants