-
Notifications
You must be signed in to change notification settings - Fork 126
adf4350: add support #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
adf4350: add support #651
Conversation
|
Generated documentation for this PR is available at Link |
Test Results1 714 tests ±0 462 ✅ ±0 12m 4s ⏱️ ±0s Results for commit 3eb82a7. ± Comparison against base commit b89168a. This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
tfcollins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need naming and doc updates
adi/adf4350.py
Outdated
| raise Exception("ADF4350 device not found") | ||
|
|
||
| @property | ||
| def frequency_altvolt0(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the channel suffix here (_altvolt0) to all the related properties as it doesn’t provide much value
|
|
||
| @frequency_altvolt0.setter | ||
| def frequency_altvolt0(self, value): | ||
| self._set_iio_attr("altvoltage0", "frequency", True, value, self._ctrl) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add docstrings for all public properties
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v2:
- drop
_altvolt0suffix - add docstrings
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase with main branch to get the build fixes.
Add pyadi-iio support for adf4350 device. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v3:
- fix conflicts
Description
Add pyadi-iio support for adf4350.
Type of change
Please delete options that are not relevant.
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Documentation
If this is a new feature or example please mention or link any documentation. All new hardware interface classes require documentation.
Checklist: